Improve the existing validation flow for sieve filter #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested from my end.
This AJAX request sends form data in $_GET request query. This is problematic and unreliable when validating superrrr loooooong conditions, especially in environments that use reverse-proxy. Been having this problem and this PR solves it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
This PR improves the existing validation method flow for sieve filter validations.
Short Description
The current validation behavior sends AJAX request form data in $_GET request query. This is problematic and unreliable when validating particularly complex and superrrr loooooooooooooong sieve rules, especially in environments that use reverse proxies--Been having this problem and this PR solves it. :)
Affected Containers
Did you run tests?
Yes.
What did you tested?
The sieve validation feature. :)
https://mail.cow.com/mailbox -> Filters Tab -> Global Prefilter/Postfilter
What were the final results? (Awaited, got)
Should show a toast notif that the sieve filter is valid or is erroneous. ;)